CP/DP Split: Collect telemetry for cp dp split #3352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3352 +/- ##
===================================================================
- Coverage 89.74% 86.69% -3.06%
===================================================================
Files 109 129 +20
Lines 11150 14855 +3705
Branches 50 62 +12
===================================================================
+ Hits 10007 12879 +2872
- Misses 1083 1829 +746
- Partials 60 147 +87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjee19
force-pushed
the
enh/collect-cp-dp-split-telemetry
branch
from
15ccd00 to
4376f41
Compare
ciarams87
approved these changes
May 1, 2025
sjberman
reviewed
May 1, 2025
sjberman
approved these changes
May 1, 2025
|
Verified changes on AIDF side. |
sjberman
pushed a commit
that referenced
this pull request
May 6, 2025
Collect telemetry for number of data plane pods, control plane pods, and nginx proxy resources attached to a gateway. Problem: With the control data plane split, there are a few telemetry metrics which need to be updated or added. Solution: Update/Add telemetry metrics.
sjberman
pushed a commit
that referenced
this pull request
May 14, 2025
Collect telemetry for number of data plane pods, control plane pods, and nginx proxy resources attached to a gateway. Problem: With the control data plane split, there are a few telemetry metrics which need to be updated or added. Solution: Update/Add telemetry metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect telemetry for number of data plane pods, control plane pods, and nginx proxy resources attached to a gateway.
Problem: With the control data plane split, there are a few telemetry metrics which need to be updated or added.
Solution: Update/Add telemetry metrics.
Testing: Manually tested these scenarios:
NginxPodCount:
ControlPlanePodCount:
GatewayAttachedNpCount:
Closes #3118
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.